Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(test-tooling): use of hardcoded password #3428

Merged
merged 1 commit into from
Oct 3, 2024
Merged

fix(test-tooling): use of hardcoded password #3428

merged 1 commit into from
Oct 3, 2024

Conversation

ashnashahgrover
Copy link
Contributor

@ashnashahgrover ashnashahgrover commented Jul 22, 2024 •
edited
Loading

Commit to be reviewed

fix(test-tooling): use of hardcoded password

Primary Changes
----------------
1. BREAKING CHANGE: "password" is now a mandatory parameter of the newEthPersonalAccount function
defined in openethereum-test-ledger.ts. It was previously optional.
2. Updated line 236 in openethereum-test-ledger.ts so the default password argument to the
newEthPersonalAccount function is not hardcoded.

Fixes #2766

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

jagpreetsinghsasan
jagpreetsinghsasan requested changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@jagpreetsinghsasan jagpreetsinghsasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you verify if the test cases requiring this piece of code clearly specifies test as the password?

@ashnashahgrover
Copy link
Contributor Author

Did you verify if the test cases requiring this piece of code clearly specifies test as the password?

@jagpreetsinghsasan There are no test cases in the repo using this code/function

petermetz
petermetz requested changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ashnashahgrover Please fix the commit lint issues and document that it's a breaking change in the commit message (which then will get recognized by the change log and put in the release notes).
You can find the expected format for breaking changes in the conventional commit messages standard.

@ashnashahgrover ashnashahgrover force-pushed the ashnashahgrover/issue2766 branch 2 times, most recently from 67e9390 to 8bdc830 Compare August 5, 2024 03:36
@ashnashahgrover
Copy link
Contributor Author

ashnashahgrover commented Aug 5, 2024 •
edited
Loading

@ashnashahgrover Please fix the commit lint issues and document that it's a breaking change in the commit message (which then will get recognized by the change log and put in the release notes). You can find the expected format for breaking changes in the conventional commit messages standard.

@petermetz I have addressed these requests.

petermetz
petermetz requested changes Aug 9, 2024
View reviewed changes
Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ashnashahgrover The breaking change is that you made a previously optional parameter of the function mandatory. It doesn't refer to line breaks in text (although those can be important too because the commit linter will fail that as well).
Please refactor the PR description/commit message accordingly.

@ashnashahgrover ashnashahgrover force-pushed the ashnashahgrover/issue2766 branch from 8bdc830 to fc55bca Compare August 11, 2024 21:22
@ashnashahgrover
Copy link
Contributor Author

@ashnashahgrover The breaking change is that you made a previously optional parameter of the function mandatory. It doesn't refer to line breaks in text (although those can be important too because the commit linter will fail that as well). Please refactor the PR description/commit message accordingly.

Have adjusted both the commit message and PR description accordingly.

@jagpreetsinghsasan
Copy link
Contributor

@ashnashahgrover The breaking change is that you made a previously optional parameter of the function mandatory. It doesn't refer to line breaks in text (although those can be important too because the commit linter will fail that as well). Please refactor the PR description/commit message accordingly.

Have adjusted both the commit message and PR description accordingly.

No it isn't updated @ashnashahgrover

CURRENT PR BODY (Breaking changes going out of the primary changes section)
image

CURRENT COMMIT MESSAGE (Breaking changes are after the fixes tag)
image

@ashnashahgrover ashnashahgrover force-pushed the ashnashahgrover/issue2766 branch from fc55bca to a6778b1 Compare August 12, 2024 19:30
petermetz
petermetz requested changes Aug 12, 2024
View reviewed changes
Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ashnashahgrover I would recommend just copy pasting the commit message to the PR description so that it's a definite match character by character and see if that fixes the PR commit parity check. You can better see the differences if you open them up next to each other on two separate browser windows like this:

image

@ashnashahgrover ashnashahgrover force-pushed the ashnashahgrover/issue2766 branch from a6778b1 to e187a84 Compare September 3, 2024 00:30
@ashnashahgrover ashnashahgrover force-pushed the ashnashahgrover/issue2766 branch from e187a84 to 3c8404b Compare September 21, 2024 00:47
@petermetz
Copy link
Contributor

Currently this one is stuck because of a pending change request from @jagpreetsinghsasan

@ashnashahgrover In case you didn't re-request review from @jagpreetsinghsasan , please do that.
@jagpreetsinghsasan If there was a re-request review then please re-review when you get the chance so that we can move this along.

I'm not sure either way where did this one get stuck, but either which way let's get in moving!

@jagpreetsinghsasan jagpreetsinghsasan dismissed their stale review October 3, 2024 03:31

Already approved by Peter

@ashnashahgrover @petermetz
fix(test-tooling): use of hardcoded password
e8c01fa 
Primary Changes
----------------
1. BREAKING CHANGE: "password" is now a mandatory parameter of the newEthPersonalAccount function
defined in openethereum-test-ledger.ts. It was previously optional.
2. Updated line 236 in openethereum-test-ledger.ts so the default password argument to the
newEthPersonalAccount function is not hardcoded.

Fixes hyperledger-cacti#2766

Signed-off-by: ashnashahgrover <as19@williams.edu>
@petermetz petermetz force-pushed the ashnashahgrover/issue2766 branch from 3c8404b to e8c01fa Compare October 3, 2024 16:12
@petermetz petermetz merged commit 63f2943 into hyperledger-cacti:main Oct 3, 2024
145 of 148 checks passed
@petermetz petermetz deleted the ashnashahgrover/issue2766 branch October 3, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@outSH outSH outSH approved these changes

@petermetz petermetz petermetz approved these changes

@jagpreetsinghsasan jagpreetsinghsasan jagpreetsinghsasan left review comments

@takeutak takeutak Awaiting requested review from takeutak takeutak is a code owner

@izuru0 izuru0 Awaiting requested review from izuru0 izuru0 is a code owner

@VRamakrishna VRamakrishna Awaiting requested review from VRamakrishna VRamakrishna is a code owner

@sandeepnRES sandeepnRES Awaiting requested review from sandeepnRES sandeepnRES is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix(test-tooling): use of hardcoded password
4 participants
@ashnashahgrover @jagpreetsinghsasan @petermetz @outSH